[U-Boot] [PATCH v6] unify version_string

Wolfgang Denk wd at denx.de
Thu Jul 28 17:30:44 CEST 2011


Dear Andreas,

In message <20110728152327.2B10A15794D5 at gemini.denx.de> I wrote:
>
> 
> In message <1311013444-74984-1-git-send-email-andreas.devel at googlemail.com>=
>  you wrote:
> > This patch removes the architecture specific implementation of
> > version_string where possible. Some architectures use a special place
> > and therefore we provide U_BOOT_VERSION_STRING definition and a common
> > weak symbol version_string.
> > >
> > Signed-off-by: Andreas Bießmann <andreas.devel at googlemail.com>
> > CC: Mike Frysinger <vapier at gentoo.org>
> > CC: Peter Pan <pppeterpppan at gmail.com>
> > Acked-by: Mike Frysinger <vapier at gentoo.org>
...
> Applied, thanks.

Oops.  NAK...

The patched code does not compile:

-> ./MAKEALL  qong
Configuring for qong board...
/home/wd/git/u-boot/work/include/version.h: Assembler messages:
/home/wd/git/u-boot/work/include/version.h:40: Error: bad instruction `extern const char version_string[]'
make[1]: *** [start.o] Error 1


Please fix.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to kill without reason
	-- Spock, "Journey to Babel", stardate 3842.4


More information about the U-Boot mailing list