[U-Boot] [PATCH 1/1] dreamplug: Initial support.

[Prafulla Wadaskar]

> -----Original Message-----
> From: Jason [mailto:u-boot at lakedaemon.net]
> Sent: Wednesday, June 08, 2011 8:38 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Siddarth Gore; Ashish Karkare; Prabhanjan
> Sarnaik
> Subject: Re: [PATCH 1/1] dreamplug: Initial support.
> 
> On Wed, Jun 08, 2011 at 12:51:01AM -0700, Prafulla Wadaskar wrote:
> >
> >
> > > -----Original Message-----
> > > From: u-boot at lakedaemon.net [mailto:u-boot at lakedaemon.net]
> > > Sent: Tuesday, June 07, 2011 11:07 PM
> > > To: u-boot at lists.denx.de
> > > Cc: Prafulla Wadaskar; Siddarth Gore; Jason Cooper
> > > Subject: [PATCH 1/1] dreamplug: Initial support.
> > >
> > > From: Jason Cooper <u-boot at lakedaemon.net>
> > >
> > > Copied files from boards/Marvell/guruplug/ and did
> > > 	s/GURUPLUG/DREAMPLUG/g
> > > 	s/guruplug/dreamplug/g
> > >
> > > Switched from NAND flash to SPI flash.
> > > 	MPP._SPI_ configuration copied from
> > > 	boards/Marvell/mv88f6281gtw_ge/mv88f6281gtw_ge.c
> > >
> 
> Prafulla,
> 

...snip..
> > > diff --git a/board/Marvell/dreamplug/Makefile
> > > b/board/Marvell/dreamplug/Makefile
> > > new file mode 100644
> > > index 0000000..b7e5270
> > > --- /dev/null
> > > +++ b/board/Marvell/dreamplug/Makefile
> > > @@ -0,0 +1,51 @@
> > > +#
> > > +# (C) Copyright 2009
> >
> > 2011 ?? and everywhere
> >
> 
> This probably needs to be fixed throughout the boards/Marvell/*
> codebase.  Can I do that since I'm not Marvell?  If so, I'll do a
> separate patch.

Anyone can contribute for the u-boot project.
In this case, not really, just think of file that you are adding newly, and correct the same in next patch post version.

> 
> > > +# Marvell Semiconductor <www.marvell.com>
> > > +# Written-by: Siddarth Gore <gores at marvell.com>
> >
> > You can say, based on or referenced from..
> > You as an author should reflect for the new files being added.
> >
> 
> Will do, but see my above comment about no original thoughts. ;-)

Just take care of code that you are adding.

Regards..
Prafulla . .