[U-Boot] [Patch V5] Add support for Bluewater Systems Snapper 9260/9G20 modules
Simon Glass
sglass at bluewatersys.com
Sat Jun 11 20:23:49 CEST 2011
Hi Reinhard,
On Sun, Jun 5, 2011 at 11:09 PM, Reinhard Meyer <u-boot at emk-elektronik.de>wrote:
> Dear Simon Glass:
> > From: Ryan Mallon <ryan at bluewatersys.com>
> >
> > Add support for Bluewater Systems AT91 based Snapper 9260 and 9G20
> > single board computer modules. Includes NAND flash and Ethernet
> > support.
> >
> > Signed-off-by: Ryan Mallon <ryan at bluewatersys.com>
> > ---
> > Build and run tested with new changes.
> >
> > Changes for v5:
> > - Previous patch was accepted but mostly lost during the commit process
> > - This re-instates the lost bits from Ryan's patch
> > - Also ran through checkpatch to clean up warnings
> How then did this escape:
>
> WARNING: please, no space before tabs
> #350: FILE: include/configs/snapper9260.h:39:
> +#define CONFIG_SYS_HZ ^I^I^I1000$
>
>
I didn't get that one, here is the output:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#150: FILE: board/bluewater/snapper9260/snapper9260.c:25:
+#include <asm/io.h>
total: 0 errors, 1 warnings, 424 lines checked
0001-Add-support-for-Bluewater-Systems-Snapper-9260-9G20-.patch has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I was using the checkpatch from 2.6.33.3 which perhaps doesn't have all the
checks. Perhaps I should upgrade.
Fixed manually.
>
Thanks.
Regards,
Simon
> > ---
> > MAINTAINERS | 5 +
> > board/bluewater/snapper9260/Makefile | 53 ++++++++
> > board/bluewater/snapper9260/snapper9260.c | 169
> +++++++++++++++++++++++++
> > include/configs/snapper9260.h | 191
> +++++++++++++++++++++++++++++
> > 4 files changed, 418 insertions(+), 0 deletions(-)
> > create mode 100644 board/bluewater/snapper9260/Makefile
> > create mode 100644 board/bluewater/snapper9260/snapper9260.c
> > create mode 100644 include/configs/snapper9260.h
>
> Applied to u-boot-atmel. Will show up later - MAKEALL at91 still running ;)
>
> Best Regards,
> Reinhard
>
More information about the U-Boot
mailing list