[U-Boot] [PATCH v2 4/6] Add generic, reusable menu code

Jason Hobbs jason.hobbs at calxeda.com
Fri Jun 24 22:25:11 CEST 2011


On Thu, Jun 23, 2011 at 10:03:12PM +0200, Wolfgang Denk wrote:
> Dear "Jason Hobbs",
> Is this all new code, or was it copied from some other project?  If
> so, reference would be needed.

All new code.

> Then, we need documentation how this is going to be used. Please add a
> README with documentation of the interfaces and usage examples.

Ok - I'll add this.

> Also, I would like to know why you didn't adapt for example the menu
> code from barebox - which specific advantages do you see in the code
> you have chosen?

I looked over barebox's menu code after you pointed it out, and
it does have more functionality and a fancier interface than this
implementation. Unfortunately, it appears that there aren't any menus
defined to use it in the barebox codebase to provide a real example for
it.

The primary advantage of the implementation I've provided over the
barebox implementation is simplicity.



More information about the U-Boot mailing list