[U-Boot] [PATCH v2 4/6] Add generic, reusable menu code

Wolfgang Denk wd at denx.de
Fri Jun 24 22:45:46 CEST 2011


Dear "Jason Hobbs",

In message <20110624202511.GA18667 at jhobbs-laptop> you wrote:
> On Thu, Jun 23, 2011 at 10:03:12PM +0200, Wolfgang Denk wrote:
> > Dear "Jason Hobbs",
> > Is this all new code, or was it copied from some other project?  If
> > so, reference would be needed.
> 
> All new code.
> 
> > Then, we need documentation how this is going to be used. Please add a
> > README with documentation of the interfaces and usage examples.
> 
> Ok - I'll add this.
> 
> > Also, I would like to know why you didn't adapt for example the menu
> > code from barebox - which specific advantages do you see in the code
> > you have chosen?
> 
> I looked over barebox's menu code after you pointed it out, and
> it does have more functionality and a fancier interface than this
> implementation. Unfortunately, it appears that there aren't any menus
> defined to use it in the barebox codebase to provide a real example for
> it.
> 
> The primary advantage of the implementation I've provided over the
> barebox implementation is simplicity.
...

Thanks for the detailed explanation.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You can't evaluate a man by logic alone.
	-- McCoy, "I, Mudd", stardate 4513.3


More information about the U-Boot mailing list