[U-Boot] [PATCH V3 5/5] I2C: add i2c support for Armada100 platform

Lei Wen adrian.wenl at gmail.com
Tue Mar 22 13:39:35 CET 2011


Hi Prafulla,

On Tue, Mar 22, 2011 at 7:40 PM, Prafulla Wadaskar <prafulla at marvell.com> wrote:
>
>
>> -----Original Message-----
>> From: Lei Wen [mailto:leiwen at marvell.com]
>> Sent: Thursday, March 17, 2011 12:15 PM
>> To: Heiko Schocher; Wolfgang Denk; Prafulla Wadaskar; u-
>> boot at lists.denx.de; Marek Vasut; Ashish Karkare; Prabhanjan Sarnaik;
>> adrian.wenl at gmail.com
>> Subject: [PATCH V3 5/5] I2C: add i2c support for Armada100 platform
>>
>> Signed-off-by: Lei Wen <leiwen at marvell.com>
>> ---
>> Changelog:
>> V3:
>> clean code sytle issue
>> Add i2c clock enable code include in I2C configure define block
>>
>>  arch/arm/cpu/arm926ejs/armada100/cpu.c    |   16 +++++++++++
>>  arch/arm/include/asm/arch-armada100/mfp.h |   40 ++++++++++++++++------
>> -------
>>  board/Marvell/aspenite/aspenite.c         |    5 +++
>>  include/configs/aspenite.h                |   12 ++++++++
>>  4 files changed, 55 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm/cpu/arm926ejs/armada100/cpu.c
>> b/arch/arm/cpu/arm926ejs/armada100/cpu.c
>> index 62aa175..c21938e 100644
>> --- a/arch/arm/cpu/arm926ejs/armada100/cpu.c
>> +++ b/arch/arm/cpu/arm926ejs/armada100/cpu.c
>> @@ -62,6 +62,16 @@ int arch_cpu_init(void)
>>       /* Enable GPIO clock */
>>       writel(APBC_APBCLK, &apb1clkres->gpio);
>>
>> +#ifdef CONFIG_I2C_MV
>> +     /* Enable general I2C clock */
>> +     writel(APBC_RST | APBC_FNCLK | APBC_APBCLK, &apb1clkres->twsi0);
>> +     writel(APBC_FNCLK | APBC_APBCLK, &apb1clkres->twsi0);
>> +
>> +     /* Enable power I2C clock */
>> +     writel(APBC_RST | APBC_FNCLK | APBC_APBCLK, &apb1clkres->twsi1);
>> +     writel(APBC_FNCLK | APBC_APBCLK, &apb1clkres->twsi1);
>> +#endif
>> +
>>       /*
>>        * Enable Functional and APB clock at 14.7456MHz
>>        * for configured UART console
>> @@ -90,3 +100,9 @@ int print_cpuinfo(void)
>>       return 0;
>>  }
>>  #endif
>> +
>> +#ifdef CONFIG_I2C_MV
>> +void i2c_clk_enable(void)
>> +{
>> +}
>
> Empty function, you can better ifdef calling line

Same reason as I explain in previous email...

Best regards,
Lei


More information about the U-Boot mailing list