[U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message

Timur Tabi b04825 at freescale.com
Thu May 5 17:04:18 CEST 2011


Kumar Gala wrote:
>>> >> That still needs some work, IMHO.  I think you might need the word
>>> >> "which" before "doesn't".  However, even with that, it's not clear
>>> >> what's wrong.  Where does the bad value of "mclk_ps" come from?
>>> >> 
>> > 
>> > It happens when the actually DDR clock is faster than the slowest DIMM
>> > can support.
>> > 
>> > York
> Did you guys agree on wording?  Is the patch ok or needs changing?

I haven't seen an updated patch from York.  I'd like to see the addition of text
like, "It happens when the actually DDR clock is faster than the slowest DIMM
can support."  People need to know what to fix, not just what's wrong.

Also, %d is for signed integers, not unsigned.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the U-Boot mailing list