[U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message

York Sun yorksun at freescale.com
Fri May 6 00:45:08 CEST 2011


On Thu, 2011-05-05 at 10:04 -0500, Timur Tabi wrote:
> Kumar Gala wrote:
> >>> >> That still needs some work, IMHO.  I think you might need the word
> >>> >> "which" before "doesn't".  However, even with that, it's not clear
> >>> >> what's wrong.  Where does the bad value of "mclk_ps" come from?
> >>> >> 
> >> > 
> >> > It happens when the actually DDR clock is faster than the slowest DIMM
> >> > can support.
> >> > 
> >> > York
> > Did you guys agree on wording?  Is the patch ok or needs changing?
> 
> I haven't seen an updated patch from York.  I'd like to see the addition of text
> like, "It happens when the actually DDR clock is faster than the slowest DIMM
> can support."  People need to know what to fix, not just what's wrong.
> 
> Also, %d is for signed integers, not unsigned.
> 

I will update the patch according to Timur's suggestion.

York





More information about the U-Boot mailing list