[U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check

Simon Guinot simon at sequanux.org
Thu May 12 13:55:21 CEST 2011


Hi Prafulla,

On Thu, May 12, 2011 at 03:17:24AM -0700, Prafulla Wadaskar wrote:
> 
> 
> > -----Original Message-----
> > From: Simon Guinot [mailto:simon.guinot at sequanux.org]
> > Sent: Thursday, May 12, 2011 3:19 PM
> > To: Prafulla Wadaskar
> > Cc: Albert ARIBAUD; u-boot at lists.denx.de; Simon Guinot
> > Subject: [PATH v7 1/2] netconsole: remove `serverip' check
> > 
> > This patch allows to enable the netconsole even if `serverip' is not
> > set.
> > 
> > Because netconsole use the environment variable `ncip' to configure the
> > destination IP, `serverip' don't need to be defined.
> > 
> > Signed-off-by: Simon Guinot <sguinot at lacie.com>
> > ---
> > Changes for v2:
> >   - restore NetOurIP check
> > 
> > Changes for v3:
> >   - add a "/* Fall through */" comment before the NETCONS case label
> > 
> > Changes for v4,5: none
> > 
> > Changes for v6:
> >   - enhance commit message
> > 
> > Changes for v7: none
> > 
> >  net/net.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> This patch looks to be independent.
> I don't have any comments for this.
> Should be applied to u-boot-net.git.

The patch itself is independent but the Network Space v2 board setup
rely on it. Without this patch, the netconsole is not usable and the
netconsole is needed to update the stock U-Boot.

IMHO, this two patches should go in the same tree, to avoid a breakage
situation.

Regards,

Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110512/b3bfb004/attachment.pgp 


More information about the U-Boot mailing list