[U-Boot] [PATH v7 1/2] netconsole: remove `serverip' check

[Prafulla Wadaskar]

> -----Original Message-----
> From: Simon Guinot [mailto:simon at sequanux.org]
> Sent: Thursday, May 12, 2011 5:25 PM
> To: Prafulla Wadaskar
> Cc: Simon Guinot; Albert ARIBAUD; u-boot at lists.denx.de; Wolfgang Denk;
> Ashish Karkare; Prabhanjan Sarnaik
> Subject: Re: [PATH v7 1/2] netconsole: remove `serverip' check
> 
> Hi Prafulla,
> 
> On Thu, May 12, 2011 at 03:17:24AM -0700, Prafulla Wadaskar wrote:
> >
> >
> > > -----Original Message-----
> > > From: Simon Guinot [mailto:simon.guinot at sequanux.org]
> > > Sent: Thursday, May 12, 2011 3:19 PM
> > > To: Prafulla Wadaskar
> > > Cc: Albert ARIBAUD; u-boot at lists.denx.de; Simon Guinot
> > > Subject: [PATH v7 1/2] netconsole: remove `serverip' check
> > >
> > > This patch allows to enable the netconsole even if `serverip' is not
> > > set.
> > >
> > > Because netconsole use the environment variable `ncip' to configure
> the
> > > destination IP, `serverip' don't need to be defined.
> > >
> > > Signed-off-by: Simon Guinot <sguinot at lacie.com>
> > > ---
> > > Changes for v2:
> > >   - restore NetOurIP check
> > >
> > > Changes for v3:
> > >   - add a "/* Fall through */" comment before the NETCONS case label
> > >
> > > Changes for v4,5: none
> > >
> > > Changes for v6:
> > >   - enhance commit message
> > >
> > > Changes for v7: none
> > >
> > >  net/net.c |    3 ++-
> > >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > This patch looks to be independent.
> > I don't have any comments for this.
> > Should be applied to u-boot-net.git.
> 
> The patch itself is independent but the Network Space v2 board setup
> rely on it. Without this patch, the netconsole is not usable and the
> netconsole is needed to update the stock U-Boot.
> 
> IMHO, this two patches should go in the same tree, to avoid a breakage
> situation.

I understand the situation, at least we need acked by respective custodians.

Copying Wolfgang for the same

Regards..
Prafulla . .