[U-Boot] [PATCH 2/2] MX53: Add initial support for MX53ARD board

Wolfgang Denk wd at denx.de
Sun May 15 11:51:14 CEST 2011


Dear Stefano,

In message <4DCF9E79.9020703 at denx.de> you wrote:
> 
> > +	/* ETHERNET_INT_B as GPIO2_31 */
> > +	mxc_request_iomux(MX53_PIN_EIM_EB3,
> > +		IOMUX_CONFIG_ALT1);
> > +	reg = readl(GPIO2_BASE_ADDR + 0x4);
> > +	reg &= ~(0x80000000);
> > +	writel(reg, GPIO2_BASE_ADDR + 0x4);
> 
> You have already included the mxc_gpio. You must use the mxc_gpio_*
> function to access gpios.

When requestiong changes like here, could you _please_ also update the
patch status in patchwork to "Changes Requested" ?

Thanks.

[Please _all_ custodians do that!]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you spell "onomatopoeia"?
A: The way it sounds.


More information about the U-Boot mailing list