[U-Boot] [PATCH v2 1/3] MX5: Make the weim structure complete

[Fabio Estevam]

Hi Stefano,

On 5/17/2011 9:44 AM, Stefano Babic wrote:
> On 05/17/2011 07:06 AM, Jason Liu wrote:
>> Hi, Fabio,
>>
>> 2011/5/17 Fabio Estevam <fabio.estevam at freescale.com>:
>>> Make the weim register set complete for MX51/MX53.
>>>
>>> While at it also add the weim chip select 1 address definition.
>>>
>>
>> From the code, you just add the cs for mx53 not for mx51, so,
>> Had better specify you add the cs1 address definition for mx53,
>> otherwise, it will make confusion.
> 
> Sure ? The structure is not protected by any CONFIG_MX5x switch, and at
> least one mx51 board uses it. The registers have the same layout for
> both processor. Why do you think is only for MX53 ?

I think what Jason mentions is the fact that I added:
#define CS1_BASE_ADDR   0xF4000000 and this was only for MX53 because it is protected by
"elif defined(CONFIG_MX53)"

I can add the CS1_BASE_ADDR for MX51 as well on my v3 series.

The weim layout registers are the same for MX51 and MX53.

Regards,

Fabi Estevam