[U-Boot] Formal acks and patchwork (was: [PATCH] [Timer]Remove calls to [get, reset]_timer outside arch/)

Wolfgang Denk wd at denx.de
Mon May 23 20:44:47 CEST 2011


Dear Albert ARIBAUD,

In message <4DDA69A1.1070009 at aribaud.net> you wrote:
> 
> > Note that this is NOT nitpicking:  Patchwork will automatically add
> > such correct Acked-by: lines to the patch, so we don't have to track
> > thse manually - this saves a LOT of time to the maintainers.
> 
> One question: where is the information presented in patchwork, apart 
> from coloring the ack line when displaying the patch discussion thread? 
> I cannot find e.g. a summary list of all acks to a given patch.

PW automatically inserts this into the patch if you click on the
"Download: mbox" link, or is you access the patch through pwclient.

For example, instead of applying a patch directly from my mailbox I
use this file only to get the hash value for the PW entry, and then
use pwclient to apply it and to update it's state:

        HASH=$(pwparser.py --hash <$PATCH)
        if [ -z "$HASH" ]
        then
                echo "ERROR: $PATCH - no such entry in PatchWork" >&2
                exit 1
        fi

        if pwclient apply -h $HASH
        then
                pwclient update -s 'Accepted' -h $HASH
        fi

This is extremely convenient as it automatically takes care of both
the Acks and the state change.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Each honest calling, each walk of life, has its own  elite,  its  own
aristocracy based on excellence of performance. - James Bryant Conant


More information about the U-Boot mailing list