[U-Boot] Formal acks and patchwork

Albert ARIBAUD albert.u.boot at aribaud.net
Mon May 23 21:19:29 CEST 2011


Le 23/05/2011 20:44, Wolfgang Denk a écrit :
> Dear Albert ARIBAUD,
>
> In message<4DDA69A1.1070009 at aribaud.net>  you wrote:
>>
>>> Note that this is NOT nitpicking:  Patchwork will automatically add
>>> such correct Acked-by: lines to the patch, so we don't have to track
>>> thse manually - this saves a LOT of time to the maintainers.
>>
>> One question: where is the information presented in patchwork, apart
>> from coloring the ack line when displaying the patch discussion thread?
>> I cannot find e.g. a summary list of all acks to a given patch.
>
> PW automatically inserts this into the patch if you click on the
> "Download: mbox" link, or is you access the patch through pwclient.
>
> For example, instead of applying a patch directly from my mailbox I
> use this file only to get the hash value for the PW entry, and then
> use pwclient to apply it and to update it's state:
>
>          HASH=$(pwparser.py --hash<$PATCH)
>          if [ -z "$HASH" ]
>          then
>                  echo "ERROR: $PATCH - no such entry in PatchWork">&2
>                  exit 1
>          fi
>
>          if pwclient apply -h $HASH
>          then
>                  pwclient update -s 'Accepted' -h $HASH
>          fi
>
> This is extremely convenient as it automatically takes care of both
> the Acks and the state change.

Thanks. Looks like this could be handy for many others. Maybe it should 
be 'backported' into pwclient itself as a new command.

> Best regards,
>
> Wolfgang Denk

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list