[U-Boot] [PATCH] [NAND] Fixes 16bit NAND support with the NDFC
Scott Wood
scottwood at freescale.com
Thu May 26 18:11:00 CEST 2011
On Thu, 26 May 2011 09:40:46 -0400
Alex Waterman <awaterman at dawning.com> wrote:
>
> I know there has been a lot of activity related to other things in the U-Boot source, but has anyone had a chance to review this patch?
Looks mostly OK to me -- I was going to consider it for next, rather than
master, as despite "fix" in the name it's really adding new hardware support.
You may want to use an #ifdef for bus width in nand_boot.c rather than
spending bytes to check it dynamically.
Likewise in the non-SPL driver code, you already have
CONFIG_SYS_NDFC_16BIT, so why check dynamically in ndfc_read_byte()?
-Scott
More information about the U-Boot
mailing list