[U-Boot] [PATCH] [NAND] Fixes 16bit NAND support with the NDFC

Alex Waterman awaterman at dawning.com
Thu May 26 20:33:59 CEST 2011


Scott,

> Looks mostly OK to me --  I was going to consider it for next, rather than
> master, as despite "fix" in the name it's really adding new hardware support.

Ahh, yeah, that makes sense. I will change "Fixes" to "Adds" for next 
submission.

> You may want to use an #ifdef for bus width in nand_boot.c rather than
> spending bytes to check it dynamically.

OK. I suppose its unlikely that a NAND chip will swap from 8bit to 16bit (or 
vice versa) from one compile to another :).

> Likewise in the non-SPL driver code, you already have
> CONFIG_SYS_NDFC_16BIT, so why check dynamically in ndfc_read_byte()?

My thought process was something along the lines of one compiled binary working
on potentially multiple similar boards... Though in thinking about it, that 
seems like a needless requirement. I will change to #ifdefs for smaller code 
size. That's probably more useful overall.

Regards,
Alex

-- 
Alex Waterman
Computer Engineer
Phone: 215-896-4920
Email: awaterman at dawning.com



More information about the U-Boot mailing list