[U-Boot] [PATCH 2/2 v6] powerpc/mpc83xx: Add 33.33MHz support for mpc8360emds

Wolfgang Denk wd at denx.de
Thu Nov 3 18:53:50 CET 2011


Dear Chang-Ming.Huang at freescale.com,

In message <1320302773-6704-2-git-send-email-Chang-Ming.Huang at freescale.com> you wrote:
> From: Jerry Huang <Chang-Ming.Huang at freescale.com>
> 
> The new MPC8360EMDS board changes the oscillator to 33.33MHz
> in order to support QE 500MHz since 2008.
...

>  MPC8360EMDS_HOST_33          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCI_33M,PQ_MDS_PIB=1
>  MPC8360EMDS_HOST_66          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCI_66M,PQ_MDS_PIB=1
>  MPC8360EMDS_SLAVE            powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCISLAVE
> +MPC8360EMDS_CLKIN33          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ
> +MPC8360EMDS_CLKIN33_ATM      powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PQ_MDS_PIB=1,PQ_MDS_PIB_ATM=1
> +MPC8360EMDS_CLKIN33_HOST_33  powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCI_33M,PQ_MDS_PIB=1
> +MPC8360EMDS_CLKIN33_HOST_66  powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCI_66M,PQ_MDS_PIB=1
> +MPC8360EMDS_CLKIN33_SLAVE    powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCISLAVE

Can you please chose somewhat shorter config names?  I consider it a
personal offense when you coerce me into typing config names like
"MPC8360EMDS_CLKIN33_HOST_33".   Please chose shorter names.   For a
start, consider  what represents the defualt configuration, and omit
all options for this, i. e. allow for a plain "MPC8360EMDS" to
represent the default configuration.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Wish not to seem, but to be, the best."                  - Aeschylus


More information about the U-Boot mailing list