[U-Boot] [PATCH 2/2 v6] powerpc/mpc83xx: Add 33.33MHz support for mpc8360emds

[Kim Phillips]

On Thu, 3 Nov 2011 18:53:50 +0100
Wolfgang Denk <wd at denx.de> wrote:

> Dear Chang-Ming.Huang at freescale.com,
> 
> In message <1320302773-6704-2-git-send-email-Chang-Ming.Huang at freescale.com> you wrote:
> > From: Jerry Huang <Chang-Ming.Huang at freescale.com>
> > 
> > The new MPC8360EMDS board changes the oscillator to 33.33MHz
> > in order to support QE 500MHz since 2008.
> ...
> 
> >  MPC8360EMDS_HOST_33          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCI_33M,PQ_MDS_PIB=1
> >  MPC8360EMDS_HOST_66          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCI_66M,PQ_MDS_PIB=1
> >  MPC8360EMDS_SLAVE            powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:PCI,PCISLAVE
> > +MPC8360EMDS_CLKIN33          powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ
> > +MPC8360EMDS_CLKIN33_ATM      powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PQ_MDS_PIB=1,PQ_MDS_PIB_ATM=1
> > +MPC8360EMDS_CLKIN33_HOST_33  powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCI_33M,PQ_MDS_PIB=1
> > +MPC8360EMDS_CLKIN33_HOST_66  powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCI_66M,PQ_MDS_PIB=1
> > +MPC8360EMDS_CLKIN33_SLAVE    powerpc     mpc83xx     mpc8360emds         freescale      -           MPC8360EMDS:CLKIN_33MHZ,PCI,PCISLAVE
> 
> Can you please chose somewhat shorter config names?  I consider it a
> personal offense when you coerce me into typing config names like
> "MPC8360EMDS_CLKIN33_HOST_33".   Please chose shorter names.   For a

right, e.g., MPC8360EMDS_33_HOST_33 would match current 8313
nomenclature.

> start, consider  what represents the defualt configuration, and omit
> all options for this, i. e. allow for a plain "MPC8360EMDS" to
> represent the default configuration.

actually I'd like the user to check their oscillator and be forced
specify the _33 or _66.

These changes should also be reflected in the documentation.

Kim