[U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU

Wolfgang Denk wd at denx.de
Sat Nov 5 14:26:10 CET 2011


Dear Albert ARIBAUD,

In message <4EB514C7.9000503 at aribaud.net> you wrote:
> 
> > +#ifndef MACH_TYPE_JADECPU
> > +#define MACH_TYPE_JADECPU	2636
> > +#endif
> 
> NAK -- remove ifndef/endif around definition. This way, if/when mach
> type reappears in official mach-type.h, we will get a warning about your
> mach-type being defined twice.

Note that you will only get a warning if a _different_ value get's
defined (``warning: "VAR" redefined'').  If both values are the same,
no warning will be raised.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the facts don't fit the theory, change the facts.
                                                   -- Albert Einstein


More information about the U-Boot mailing list