[U-Boot] [PATCH] arm: jadecpu: Readd MACH_TYPE_JADECPU
Albert ARIBAUD
albert.u.boot at aribaud.net
Sat Nov 5 15:09:51 CET 2011
Le 05/11/2011 14:26, Wolfgang Denk a écrit :
> Dear Albert ARIBAUD,
>
> In message<4EB514C7.9000503 at aribaud.net> you wrote:
>>
>>> +#ifndef MACH_TYPE_JADECPU
>>> +#define MACH_TYPE_JADECPU 2636
>>> +#endif
>>
>> NAK -- remove ifndef/endif around definition. This way, if/when mach
>> type reappears in official mach-type.h, we will get a warning about your
>> mach-type being defined twice.
>
> Note that you will only get a warning if a _different_ value get's
> defined (``warning: "VAR" redefined''). If both values are the same,
> no warning will be raised.
Hmm, correct. In order to catch the mach-type creeping back in
mach-types.h, we'd need to define something like
#define MACH_TYPE_JADECPU (2636)
I'll post an ARM-global patch for this, but as it will obviously not be
a bugfix, it'll wait until next merge window.
> Best regards,
>
> Wolfgang Denk
Amicalement,
--
Albert.
More information about the U-Boot
mailing list