[U-Boot] checkpatch compliance

Wolfgang Denk wd at denx.de
Thu Nov 17 21:54:04 CET 2011


Dear Gerlando Falauto,

In message <4EC56A2E.2000708 at keymile.com> you wrote:
>
> What is wrong with something like:
> 
> ERROR: do not initialise statics to 0 or NULL
> #35: FILE: serial.c:32:
> +static struct serial_device *serial_devices = NULL;
> 
> ERROR: do not initialise statics to 0 or NULL
> #36: FILE: serial.c:33:
> +static struct serial_device *serial_current = NULL;
> 
> Since it's a bootloader, should we also ignore it with:

Why?  Why don't you just follow the advise and remove the redundant
initializers?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't you know anything? I should have thought anyone knows that  who
knows anything about anything...      - Terry Pratchett, _Soul Music_


More information about the U-Boot mailing list