[U-Boot] [PATCH 1/2] efikamx: Configure the pins as GPIOs prior to using gpio_get_value.

[Mike Frysinger]

On Monday 21 November 2011 09:20:49 Marek Vasut wrote:
> > Configure the pins as GPIOs prior to using gpio_get_value
> > 
> > +	else {
> > +		mxc_request_iomux(MX51_PIN_GPIO1_8, IOMUX_CONFIG_ALT0);
> >  		*absent = gpio_get_value(IOMUX_TO_GPIO(MX51_PIN_GPIO1_8));
> > -
> > +	}
> >  	return 0;
> >  }
> 
> NAK. There should be some common function for setting up iomux of those
> pins. You souldn't set it in repeatedly called functions.

that's what gpio_request() is for
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111121/3b8c1ce4/attachment.pgp>