[U-Boot] [PATCH 1/2] efikamx: Configure the pins as GPIOs prior to using gpio_get_value.

Marek Vasut marek.vasut at gmail.com
Mon Nov 21 20:29:50 CET 2011


> On Monday 21 November 2011 09:20:49 Marek Vasut wrote:
> > > Configure the pins as GPIOs prior to using gpio_get_value
> > > 
> > > +	else {
> > > +		mxc_request_iomux(MX51_PIN_GPIO1_8, IOMUX_CONFIG_ALT0);
> > > 
> > >  		*absent = gpio_get_value(IOMUX_TO_GPIO(MX51_PIN_GPIO1_8));
> > > 
> > > -
> > > +	}
> > > 
> > >  	return 0;
> > >  
> > >  }
> > 
> > NAK. There should be some common function for setting up iomux of those
> > pins. You souldn't set it in repeatedly called functions.
> 
> that's what gpio_request() is for

I mean in efika.c ... there should be a common place for these iomux 
configurations being done. This is unrelated to gpio ...

> -mike


More information about the U-Boot mailing list