[U-Boot] [PATCH] arm, post: add missing post_time_ms for arm

Prafulla Wadaskar prafulla at marvell.com
Tue Nov 22 09:26:04 CET 2011



> -----Original Message-----
> From: Heiko Schocher [mailto:hs at denx.de]
> Sent: Monday, November 21, 2011 7:40 PM
> To: Holger Brunck
> Cc: u-boot at lists.denx.de; Longchamp, Valentin; Falauto,
> Gerlando
> Subject: Re: [PATCH] arm, post: add missing post_time_ms for
> arm
> 
> Hello Holger,
> 
> 
> added Prafulla Wadaskar to cc ...
> 
> Holger Brunck wrote:
> > Hi Heiko,
> >
> > On 09/15/2011 07:34 AM, Heiko Schocher wrote:
> >> Signed-off-by: Heiko Schocher <hs at denx.de>
> >> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> >> ---
> >>  post/post.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/post/post.c b/post/post.c
> >> index 6c59f91..0bfca75 100644
> >> --- a/post/post.c
> >> +++ b/post/post.c
> >> @@ -488,7 +488,7 @@ void post_reloc(void)
> >>   */
> >>  unsigned long post_time_ms(unsigned long base)
> >>  {
> >> -#ifdef CONFIG_PPC
> >> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
> >>  	return (unsigned long)(get_ticks() / (get_tbclk() /
> CONFIG_SYS_HZ))
> >>  		- base;
> >>  #else
> >
> > this commit breaks post test support for our keymile arm
> boards:
> 
> :-(
> 
> I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post
> support
> worked for you before this patch? You should have seen this
> warning message:
> 
> #warning "Not implemented yet"
> 
> or?
> 
> >> make km_kirkwood
> > [...]
> > post/libpost.o: In function `post_time_ms':
> > /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
> reference to `get_ticks'
> > /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined
> reference to `get_tbclk'
> >
> > So it seems that the kirkwood code has no implementation for
> these functions.
> > Any idea how to fix this?
> 
> We must implement it ... Prafulla, can you comment this?

As per my knowledge Kirkwood has no implementation for this.
Yes, we should implement this.
Patches are welcomed.

Regards..
Prafulla . . .


More information about the U-Boot mailing list