[U-Boot] [PATCH v3 3/3] arm, davinci: add support for am1808 based enbw_cmc board

[Wolfgang Denk]

Dear Igor Grinberg,

it is really not necessary to quote 1300+ lines of unrelated code.
Just provide sufficient context for your remarks.

In message <4ED373C6.5020906 at compulab.co.il> you wrote:
> 
> > +		ret = gpio_request(gpio, enbw_gpio_config[i].name);
> > +		if (ret)
> > +			printf("%s: Could not get %s gpio\n", __func__,
> > +				enbw_gpio_config[i].name);
> > +		else
> 
> instead of having that else and adding another level of indentation below
> you can just add continue;

Really?  There is no return in this error handling, so why do you
think we should continue to run this code even after an error?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It would be illogical to assume that all conditions remain stable
	-- Spock, "The Enterprise" Incident", stardate 5027.3