[U-Boot] [PATCH v3 3/3] arm, davinci: add support for am1808 based enbw_cmc board

Heiko Schocher hs at denx.de
Tue Nov 29 07:56:13 CET 2011


Hello Wolfgang,

Wolfgang Denk schrieb:
> Dear Heiko Schocher,
> 
> In message <4ED3A6A8.5010301 at denx.de> you wrote:
>>>> +		ret = gpio_request(gpio, enbw_gpio_config[i].name);
>>>> +		if (ret)
>>>> +			printf("%s: Could not get %s gpio\n", __func__,
>>>> +				enbw_gpio_config[i].name);
>>>> +		else
>>> instead of having that else and adding another level of indentation below
>>> you can just add continue;
>> Done.
> 
> Is this really a good idea??

Fixed that. If there is an error, we return instead.

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list