[U-Boot] [PATCH v2 4/7] mmc: dcache: allocate cache aligned buffer for scr and switch_status

Wolfgang Denk wd at denx.de
Thu Oct 6 20:45:08 CEST 2011


Dear Anton Staaf,

In message <1317763491-7274-5-git-send-email-robotboy at chromium.org> you wrote:
> Currently the sd_change_freq function allocates two buffers on the
> stack that it passes down to the MMC device driver.  These buffers
> could be unaligned to the L1 dcache line size.  This causes problems
> when using DMA and with caches enabled.
> 
> This patch correctly cache alignes the buffers used for reading the
> scr register and switch status values from an MMC device.
> 
> Signed-off-by: Anton Staaf <robotboy at chromium.org>
> Acked-by: Mike Frysinger <vapier at gentoo.org>
> Cc: Lukasz Majewski <l.majewski at samsung.com>
> Cc: Mike Frysinger <vapier at gentoo.org>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> ---
>  drivers/mmc/mmc.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra


More information about the U-Boot mailing list