[U-Boot] [PATCH 3/3] powerpc/85xx: wait for alignment before resetting SERDES RX lanes (SERDES9)

Timur Tabi timur at freescale.com
Thu Oct 6 23:07:13 CEST 2011


Wolfgang Denk wrote:

> WARNING: externs should be avoided in .c files
> #114: FILE: board/freescale/corenet_ds/eth_p4080.c:100:
> +       extern struct phy_driver tn2020_driver;

This is intentional.  There's no header file for the teranetics driver, and
referencing the structure allows me to avoid a hard-coded number.

Are you suggesting that I create a header file just to contain this line:

	extern struct phy_driver tn2020_driver;

because that seems silly.

-- 
Timur Tabi
Linux kernel developer at Freescale



More information about the U-Boot mailing list