[U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

Wolfgang Denk wd at denx.de
Sun Oct 9 21:43:36 CEST 2011


Dear Lukasz Majewski,

In message <20111007093950.17d94287 at lmajewski.digital.local> you wrote:
>
> Most warnings are related to lines over 80 characters. 
> This code is a debug code. As fair as I remember debug print code shall
> not be break in Linux kernel for easier debugging.

Can you please point me to the respective entry in the CodingStyle
file?

> I don't know what is the policy in u-boot. I haven't seen any guideline
> about breaking debug code when it is larger than 80 characters (so I
> stick to kernel policy).

We make no distinction between different "types" of code.

> Other warnings are related to kernel API (like the min() macro usage)
> which is different in u-boot.

So it needs to be fixed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A supercomputer is a machine that runs an endless loop in 2 seconds.


More information about the U-Boot mailing list