[U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

Scott Wood scottwood at freescale.com
Mon Oct 10 22:00:53 CEST 2011


On 10/09/2011 02:43 PM, Wolfgang Denk wrote:
> Dear Lukasz Majewski,
> 
> In message <20111007093950.17d94287 at lmajewski.digital.local> you wrote:
>>
>> Most warnings are related to lines over 80 characters. 
>> This code is a debug code. As fair as I remember debug print code shall
>> not be break in Linux kernel for easier debugging.
> 
> Can you please point me to the respective entry in the CodingStyle
> file?

Note the last sentence:

>                 Chapter 2: Breaking long lines and strings
> 
> Coding style is all about readability and maintainability using commonly
> available tools.
> 
> The limit on the length of lines is 80 columns and this is a strongly   
> preferred limit.
> 
> Statements longer than 80 columns will be broken into sensible chunks, unless
> exceeding 80 columns significantly increases readability and does not hide
> information. Descendants are always substantially shorter than the parent and
> are placed substantially to the right. The same applies to function headers
> with a long argument list. However, never break user-visible strings such as
> printk messages, because that breaks the ability to grep for them.

-Scott



More information about the U-Boot mailing list