[U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201110101118.05350.vapier at gentoo.org> you wrote:
>
> > > >>      defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \
> > > >>      defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \
> > > >>      defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \
> > > >> -    defined(CONFIG_TEGRA2)
> > > >> +    defined(CONFIG_TEGRA2) || defined(CONFIG_MICROBLAZE)
> > > > 
> > > > Am I the only one that thinks this is all really ugly?
> > > 
> > > I hope you mean serial.h not mb code.
> > > 
> > > I agree with you but not sure if we can remove all ifdefs there.
> > 
> > The long list of device specific ifdef's should be converted into a
> > single ifdef testing for a specific feature instead.
> 
> it's driver specific code in this file, so it doesn't make much sense to have 
> the board config define something just to get these prototypes

It could be a CPU specific header file, then.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Deliver yesterday, code today, think tomorrow."