[U-Boot] [PATCH] microblaze: Enable SERIAL_MULTI

[Mike Frysinger]

On Monday 10 October 2011 13:35:13 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > > >>      defined(CONFIG_MB86R0x) || defined(CONFIG_MPC5xxx) || \
> > > > >>      defined(CONFIG_MPC83xx) || defined(CONFIG_MPC85xx) || \
> > > > >>      defined(CONFIG_MPC86xx) || defined(CONFIG_SYS_SC520) || \
> > > > >> 
> > > > >> -    defined(CONFIG_TEGRA2)
> > > > >> +    defined(CONFIG_TEGRA2) || defined(CONFIG_MICROBLAZE)
> > > > > 
> > > > > Am I the only one that thinks this is all really ugly?
> > > > 
> > > > I hope you mean serial.h not mb code.
> > > > 
> > > > I agree with you but not sure if we can remove all ifdefs there.
> > > 
> > > The long list of device specific ifdef's should be converted into a
> > > single ifdef testing for a specific feature instead.
> > 
> > it's driver specific code in this file, so it doesn't make much sense to
> > have the board config define something just to get these prototypes
> 
> It could be a CPU specific header file, then.

some of these drivers are shared across SoCs/arches :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111010/368a1b28/attachment.pgp