[U-Boot] [PATCH 3/4] davinci: emac: add support for more than 1 PHYs

[Hadli, Manjunath]

Laurence,
On Sat, Oct 01, 2011 at 01:59:30, Laurence Withers wrote:
> On Fri, Sep 30, 2011 at 05:27:11PM +0530, nagabhushana.netagunte at ti.com wrote:
> > add support for more than 1 PHYs. Many of the davinci platforms have 
> > more than 1 PHYs on thier board. This patch extends support in davinci 
> > emac driver for upto 3 PHYs.
> 
> As a nitpick, there is a typo in "thier", which should be "their".
Thanks!

> 
> But a real question: where does the number 3 come from? It seems rather arbitrary, at least without any explanatory comments. The MDIO interface can support up to 31 devices, so perhaps you should allow for that many PHYs?
> (Or perhaps a limit configurable with a #define, as it would seem wasteful to allocate memory for 31 phy_t structures when I doubt there are any boards that could truly take advantage of that).
Agreed. The reason why it is 3 is because it is currently detecting only 3 at the max (on DA830), although the support is for 32 nos. We will #define it is 3 and latter boards can possibly change that depending on the board support.

Thx and Regards,
-Mat anju
> 
> Bye for now,
> -- 
> Laurence Withers, <lwithers at guralp.com>                http://www.guralp.com/
> Direct tel:+447753988197 or tel:+443333408643               Software Engineer
> General support queries: <support at guralp.com>         CMG-DCM CMG-EAM CMG-NAM
>