[U-Boot] [STATUS] "Quality" of patches / testing.

Lukasz Majewski l.majewski at samsung.com
Tue Oct 18 12:24:16 CEST 2011


Hi,

> I guess it will be doable to have some scripts/prepare-patch which
> runs a) git format-patch
>  b) checkpatch on the patch

I'm a bit confused.

Joe Hershberger has prepared a following patch:

http://patchwork.ozlabs.org/patch/119083/

Is this THE ONE checkpatch version which we shall use (including its
config file)? 

I've used it for my patch sets and I can say that warnings like:

WARNING: min() should probably be min_t(unsigned int, amount_left,
mod_data.buflen) 

and

WARNING: consider using kstrto* in preference to simple_strtoul
#4358:

are still present.

Those are Linux kernel specific.

Shall I not care about them and submit patches with non zero warnings
output from checkpatch?

-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group


More information about the U-Boot mailing list