[U-Boot] [STATUS] "Quality" of patches / testing.

Wolfgang Denk wd at denx.de
Tue Oct 18 13:02:50 CEST 2011


Dear Lukasz Majewski,

In message <20111018122416.483205d6 at lmajewski.digital.local> you wrote:
> 
> Joe Hershberger has prepared a following patch:
> 
> http://patchwork.ozlabs.org/patch/119083/
> 
> Is this THE ONE checkpatch version which we shall use (including its
> config file)? 

It shall become it, yes.

> I've used it for my patch sets and I can say that warnings like:
> 
> WARNING: min() should probably be min_t(unsigned int, amount_left,
> mod_data.buflen) 
> 
> and
> 
> WARNING: consider using kstrto* in preference to simple_strtoul
> #4358:
> 
> are still present.
> 
> Those are Linux kernel specific.
> 
> Shall I not care about them and submit patches with non zero warnings
> output from checkpatch?

Neither one nore the other.  Help adapting the checkpatch config file
to our needs, so that things like simple_strtoul() don't throw such
warnings in U-Boot context.

Then submit zero warning patches...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
People seldom know what they want until you give them what  they  ask
for.


More information about the U-Boot mailing list