[U-Boot] [PATCH] arm, doc: add CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST documentation

Heiko Schocher hs at denx.de
Wed Oct 19 07:48:53 CEST 2011


Hello Tom,

added Sandeep Paulraj to cc, as he is the ti custodian ...

Tom Rini wrote:
> Ah, but we asked (and you agreed) to name the option generically since

Where do you read, that I agreed to rename this config option?

I just wrote:

http://lists.denx.de/pipermail/u-boot/2011-October/104784.html

"Ok, you are right, there is no documentation of this config option.
Should I add this documentation in this patch or in a seperate patch?"

and Wolfgang Denk said here:

http://lists.denx.de/pipermail/u-boot/2011-October/104786.html

"Separate, please.  Thanks."

...

> it's about OOB position rather than ECC size.  And the help should
> reflect that it's about changing the OOB position relative to data as
> foudn on some davinci platforms rather than just being to enable
> support in davinci SoCs.  Other boards might need this :)

Maybe I oversee something, but as I see in Code, this feature is
davinci only (as this is a CPU feature) ... Ah, maybe I got it!

I added this option to "drivers/mtd/nand/nand_spl_simple.c" and there
it should get a more common name, right? ...

Ok, so I see the following to do:

rework patch:
http://lists.denx.de/pipermail/u-boot/2011-October/104769.html

- rename "CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST" to
  "CONFIG_SYS_NAND_ECC_OOBFIRST"?
- add a doc for this new config option
- add this new config option to the enbw_cmc board support

This doc patch:
http://lists.denx.de/pipermail/u-boot/2011-October/104907.html

- This can go to mainline, as it just documents the existing
  CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST config option for davinci
  socs.

Ok?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list