[U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

Stefan Roese sr at denx.de
Wed Oct 19 09:48:48 CEST 2011


Hi Dirk,

On Wednesday 19 October 2011 08:34:00 Dirk Eibach wrote:
> Signed-off-by: Dirk Eibach <eibach at gdsys.de>
> ---
> Changes for v2:
>   - fixed parameters for memset() in pca9698_set_output()

Thanks.

While looking again, I noticed that you are not using the "standard" GPIO API 
borrowed from Linux. Please take a look at drivers/gpio/mxc_gpio.c or 
drivers/gpio/mvgpio.c as an example.

Sorry for not mentioning this earlier. Could you please update this patch and 
your Io64 BSP patch by using this "standard" GPIO API?

Thanks.

Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list