[U-Boot] [PATCH v2] gpio: Add PCA9698 40-bit I2C I/O port

Eibach, Dirk Eibach at gdsys.de
Wed Oct 19 10:37:26 CEST 2011


 
Hi Stefan.

> While looking again, I noticed that you are not using the 
> "standard" GPIO API borrowed from Linux. Please take a look 
> at drivers/gpio/mxc_gpio.c or drivers/gpio/mvgpio.c as an example.
> 
> Sorry for not mentioning this earlier. Could you please 
> update this patch and your Io64 BSP patch by using this 
> "standard" GPIO API?

I see that the drivers you mentioned are for processor gpio, mine is for
an i2c port expander.
The gpio API "implementation" in these drivers is a mess because it does
not support managing multiple gpio providers. Using this API would make
it impossible to use pca9698 on such platforms. If someone decided to
build a processor gpio driver like this for ppc4xx we would even have a
collision for Io64.

Until the whole GPIO API idea is more refined I am not too happy
adapting pca9698 implementation.
Do you insist?

Cheers
Dirk




More information about the U-Boot mailing list