[U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

[Wolfgang Denk]

Dear Doug Anderson,

In message <1319063459-4804-2-git-send-email-dianders at chromium.org> you wrote:
> It appears that there are a handful of places in u-boot that we want
> to munge the linux command line.  This adds some helper functions that
> make that easier.
> 
> Signed-off-by: Doug Anderson <dianders at chromium.org>
> ---
>  common/Makefile   |    1 +
>  common/cmdline.c  |  318 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/cmdline.h |   30 +++++
>  3 files changed, 349 insertions(+), 0 deletions(-)
>  create mode 100644 common/cmdline.c
>  create mode 100644 include/cmdline.h

Sorry, but could you please explain why anybody would need this?

Instead of adding tons of code to process one environment variable
that happens to be passed to Linux, but otherwise is not different
form any of the other variables, you can as well just use plain simple
shell scripting capabilities to build your Linux command line from
pieces.  This is way more flexible and much less resource consuming.

Unless you have a really good explanation why such coude is needed I
tend to NAK it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As in certain cults it is possible to kill a process if you know  its
true name.                      -- Ken Thompson and Dennis M. Ritchie