[U-Boot] [PATCH 1/4] cmdline: Add linux command line munging tools

[Doug Anderson]

Wolfgang,

On Thu, Oct 20, 2011 at 7:36 AM, Wolfgang Denk <wd at denx.de> wrote:

> Sorry, but could you please explain why anybody would need this?
>

I'm happy to explain.  :)  In our setup, the Linux command line is
constructed (in part) by reading from the disk.  When we load the kernel, we
also load the kernel command line.  It is convenient for us if this kernel
command line on disk continues to have things like "console=/dev/ttyS0" and
"earlyprintk" in it so that we can swap between release (no console) and
development (with console) by just tweaking a settings in u-boot.

Certainly we could change our setup, but the prior existence
of fixup_silent_linux() indicated that this might be a common way to do
things.

In the case of Chromium OS, we also do some additional programmatic munging
of the command line for verified boot purposes, but since that is not
upstream it's not really a good argument for making the more general
function.

In any case, I already have the more direct (and less generalized) version
of fixup_silent_linux() written and will send out a patch with just that
shortly.

Based on your comments, I'll assume that you're not interested in the more
general command line munging tools and will abandon them for now until there
is a clear need for them.

Thanks for your review!

-Doug