[U-Boot] [PATCH v2 00/11] Define ARCH_DMA_MINALIGN for all architectures

[Anton Staaf]

On Mon, Oct 17, 2011 at 4:46 PM, Anton Staaf <robotboy at chromium.org> wrote:
> ARCH_DMA_MINALIGN is a new define borrowed from the Linux kernel.  It is
> used to define the minimum alignement requirement for a DMA buffer.  This
> series of patches ensures that it will always be defined in the arch specific
> asm/cache.h header and that asm/cache.h is included in common.h.  I chose to
> add this new define instead of reusing CONFIG_SYS_CACHELINE_SIZE for two
> reasons.  First, CONFIG_SYS_CACHELINE_SIZE is not defined for all architectures
> and thus to use it I would have to first define it correctly for all used
> architectures.  I wasn't quite up to that task right now.  Defining
> ARCH_DMA_MINALIGN is easier because it has slightly different semantics that
> allow it to be the maximum cacheline size known for an architecture.  And
> secondly, CONFIG_SYS_CACHELINE_SIZE may not always be the correct value to use
> to align DMA buffers.  In particular, on cache coherent architectures you can
> define ARCH_DMA_MINALIGN as 1 and be safe (unless there are other restrictions
> such as PCI alignment requirements).
>
> This patch set will allow me to resubmit my ALLOC_CACHE_ALIGN_BUFFER patch set
> modified to use this new define in place of CONFIG_SYS_CACHELINE_SIZE.  I will
> repost those patches based on this set shortly.
>
> Since we've heard no complaints and have an ack for PowerPC at least, I think
> this can go in as is.  It's defining a new macro that isn't used yet and I
> believe that each architecture has a reasonable value defined now.
>
> Thanks,
>    Anton
>
> Changes in v2:
> - Remove blackfin patches in favor of Mike's import of the Linux kernel cache.h
> - Remove all Gerrit Change-ID tags

I have now run MAKEALL for both ARMv7a and PowerPC successfully.
There were a number of
build failures for "powerpc", but no new ones given my patch.  I'd
like to land this soon
so I can get to landing the fixes for the unaligned buffers in U-Boot.

Thanks,
    Anton

> Anton Staaf (11):
>  arm: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  m68k: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  nios2: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  powerpc: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  sh: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  sparc: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  avr32: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  microblaze: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  mips: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  x86: cache: define ARCH_DMA_MINALIGN for DMA buffer alignment
>  cache: include asm/cache.h for ARCH_DMA_MINALIGN definition
>
>  arch/arm/include/asm/cache.h        |   11 +++++++++
>  arch/avr32/include/asm/cache.h      |   40 +++++++++++++++++++++++++++++++++++
>  arch/m68k/include/asm/cache.h       |   10 ++++++++
>  arch/microblaze/include/asm/cache.h |   37 ++++++++++++++++++++++++++++++++
>  arch/mips/include/asm/cache.h       |   36 +++++++++++++++++++++++++++++++
>  arch/nios2/include/asm/cache.h      |   11 +++++++++
>  arch/powerpc/include/asm/cache.h    |    6 +++++
>  arch/sh/include/asm/cache.h         |   17 ++++++++++++++
>  arch/sparc/include/asm/cache.h      |   10 ++++++++
>  arch/x86/include/asm/cache.h        |   35 ++++++++++++++++++++++++++++++
>  include/common.h                    |    8 +++++++
>  11 files changed, 221 insertions(+), 0 deletions(-)
>  create mode 100644 arch/avr32/include/asm/cache.h
>  create mode 100644 arch/microblaze/include/asm/cache.h
>  create mode 100644 arch/mips/include/asm/cache.h
>  create mode 100644 arch/x86/include/asm/cache.h
>
> --
> 1.7.3.1
>
>