[U-Boot] [PATCH] I2C: Fix mxc_i2c.c problem on phycore pcm037

Anatolij Gustschin agust at denx.de
Tue Oct 25 16:59:25 CEST 2011


Hi Marek,

On Tue, 25 Oct 2011 14:09:11 +0200
Marek Vasut <marek.vasut at gmail.com> wrote:

> The problem was caused by a global variable being used early in the boot
> process.
> 
> This patch also contains the multibyte address swapping fix by:
>   Anatolij Gustschin <agust at denx.de>
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> Cc: Anatolij Gustschin <agust at denx.de>
> Cc: Wolfgang Denk <wd at denx.de>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
>  drivers/i2c/mxc_i2c.c |   29 ++++++++++++++++-------------
>  1 files changed, 16 insertions(+), 13 deletions(-)

Great, this patch fixes the issue! Thanks!

Tested-by: Anatolij Gustschin <agust at denx.de>

But, I think we should slightly fix the commit title and commit
message to describe the observed problem better.

The board is named as "imx31_phycore" in the code, config
file uses this name, too. So we should use "imx31_phycore" name in
U-Boot commits instead of pcm037 to avoid confusion for other users
(pcm037 name is used in Linux code for this board).

In the commit message we should also mention what the problem was:
on imx31_phycore board reading the environment from I2C EEPROM
didn't work correctly.

Thanks,
Anatolij

--
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list