[U-Boot] [PATCH 01/39] DEBUG: Fix debug macros

馬克泡 macpaul at gmail.com
Tue Oct 25 22:40:56 CEST 2011


Hi all,

2011/10/26 Joe Hershberger <joe.hershberger at gmail.com>:
> On Sun, Oct 23, 2011 at 12:12 PM, Wolfgang Denk <wd at denx.de> wrote:
>> Dear Mike Frysinger,
>>
> I'm working on a patch for the net code that benefits from the debugX
> macro.  Especially for the net code, the debug traces can be
> overwhelming depending on the issue you are looking at.  I recommend
> we keep it around.
>
> Thanks
> -Joe

I agreed with Joe,

I feel some debug code is necessary to keep it into levels since some
you usually need to split debug level into 2 or 3 to help the debug work.
A device driver which has been commit into the mainline source should be
worked on most of platforms. However, it still might be need to do debug work
on several different platform since the hardware integration might be different
then introduce problem. Hence the debug codes in detail should not be removed
in the mainline code, and it should be labeled with some debug levels.
Those code will help the debug work in future.

Moreover, some device driver will need to be fixed when the hardware
will be fixed
or upgraded and introduce different versions. Those hardware still
follow a common
behaviors, a common set of registers, even the 50% usage of the driver
will be same.
Hence keep debug code in deep level will be help.

We can keep it until someone really have time to fix it.

-- 
Best regards,
Macpaul Lin


More information about the U-Boot mailing list