[U-Boot] [PATCH 01/39] DEBUG: Fix debug macros

[Wolfgang Denk]

Dear =?UTF-8?B?6aas5YWL5rOh?=,

In message <CACCg+XP8zoKGproJ4t=QEQU4ZFYccAPPjsGkz72BKBwowcUQng at mail.gmail.com> you wrote:
>
> > I'm working on a patch for the net code that benefits from the debugX
> > macro.  Especially for the net code, the debug traces can be
> > overwhelming depending on the issue you are looking at.  I recommend
> > we keep it around.
...
> I agreed with Joe,

And I disagree.

After 11 years of U-Boot development, after collecting 2,515 C files,
we have just 2 (in words: TWO) files that use this macro.  And one of
them with a single level only, so it's even useless there.

> I feel some debug code is necessary to keep it into levels since some
> you usually need to split debug level into 2 or 3 to help the debug work.

Usually?  In a single case out of 2.5k files?  That's not usual,
that's a mistake.


I say: we get rid of this!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
       There is enough for the need of everyone in this world,
       but not for the greed of everyone.     - Mahatma Gandhi