[U-Boot] [PATCH v2 6/6] net: Export auto_load, use it in rarp

Simon Glass sjg at chromium.org
Fri Oct 28 00:24:35 CEST 2011


Hi Mike,

On Thu, Oct 27, 2011 at 2:12 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Thu, Oct 27, 2011 at 18:24, Simon Glass wrote:
>> The rarp code includes another instance of the auto_load logic, so call
>> what is now net_auto_load() instead.
>
> Acked-by: Mike Frysinger <vapier at gentoo.org>
>
>> This also fixes an incorrect call to TftpStart() which was never seen
>> since apparently no boards enable rarp.
>
> i wonder if we shouldn't just drop rarp then if no one actually uses it ...
> -mike
>

Well that's the definition of dead code, but of course there may be
thousands of boards out there that use it, where the code is not
upstream. I suppose we could take the code out and see if anyone
notices :-) It is at least in a separate file and not built unless
requested.

Regards,
Simon


More information about the U-Boot mailing list