[U-Boot] [PATCH v2 6/6] net: Export auto_load, use it in rarp

Mike Frysinger vapier at gentoo.org
Fri Oct 28 00:40:14 CEST 2011


On Fri, Oct 28, 2011 at 00:24, Simon Glass wrote:
> On Thu, Oct 27, 2011 at 2:12 PM, Mike Frysinger wrote:
>> On Thu, Oct 27, 2011 at 18:24, Simon Glass wrote:
>>> This also fixes an incorrect call to TftpStart() which was never seen
>>> since apparently no boards enable rarp.
>>
>> i wonder if we shouldn't just drop rarp then if no one actually uses it ...
>
> Well that's the definition of dead code, but of course there may be
> thousands of boards out there that use it, where the code is not
> upstream. I suppose we could take the code out and see if anyone
> notices :-) It is at least in a separate file and not built unless
> requested.

i think our (reasonable) position is that if no one is using it, and
no one is noticing when it breaks, then we should simply drop it.  if
out of tree boards cared, they'd be in tree.

i like to think that the barrier for inclusion in u-boot is
significantly lower than the linux kernel ...
-mike


More information about the U-Boot mailing list