[U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

Wolfgang Denk wd at denx.de
Sun Oct 30 14:12:30 CET 2011


Dear Marek Vasut,

In message <201110300047.46696.marek.vasut at gmail.com> you wrote:
>
> >  /*------------------------------------------------------------------------
> > --*/ +#ifndef MACH_TYPE_EB_CPUX9K2
> > +#define MACH_TYPE_EB_CPUX9K2           1977
> > +#endif
> > +/*------------------------------------------------------------------------
> > --*/ #define CONFIG_SYS_TEXT_BASE 		0x00000000
> >  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load address */
> 
> You don't need the ifndef. Cheers

But it doesn;t hurt either.  I consider it defensive programming, just
in case the #defined gets re-added to machtypes.h.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Unix is simple, but it takes a genius to understand the simplicity."
					             - Dennis Ritchie


More information about the U-Boot mailing list