[U-Boot] [PATCH] ARM: re-introduce the MACH_TYPE_XXXXXX for EB_CPUX9K2 board

[Marek Vasut]

> Dear Marek Vasut,
> 
> In message <201110300047.46696.marek.vasut at gmail.com> you wrote:
> > >  /*--------------------------------------------------------------------
> > >  ----
> > > 
> > > --*/ +#ifndef MACH_TYPE_EB_CPUX9K2
> > > +#define MACH_TYPE_EB_CPUX9K2           1977
> > > +#endif
> > > +/*--------------------------------------------------------------------
> > > ---- --*/ #define CONFIG_SYS_TEXT_BASE 		0x00000000
> > > 
> > >  #define CONFIG_SYS_LOAD_ADDR		0x21000000  /* default load 
address */
> > 
> > You don't need the ifndef. Cheers
> 
> But it doesn;t hurt either.  I consider it defensive programming, just
> in case the #defined gets re-added to machtypes.h.
> 
> Best regards,
> 
> Wolfgang Denk

Sure, but if the machine ID is re-added, we will get a warning in here without 
the ifdefs. With the ifdefs, the machine ID might be different here and in the 
mach-types file and it might slide unnoticed.