[U-Boot] [PATCH v4 0/4] Add basic clock and pinmux functions to the Tegra2

[Mike Frysinger]

On Wednesday, August 31, 2011 18:02:40 Simon Glass wrote:
> On Tue, Aug 30, 2011 at 7:47 PM, Mike Frysinger wrote:
> > On Tuesday, August 30, 2011 12:53:20 Albert ARIBAUD wrote:
> >> Patch series applied to u-boot-arm/master, with manual fix of three
> >> empty lines at EOF in patches 1 through 3.
> >> 
> >> These empty lines and other whitespace errors can be found and fixed by
> >> the submitter before sending the patch to the list: just apply the
> >> patches to a local branch created at the intended commit where
> > 
> >> application will happen, i.e.:
> > checkpatch.pl should catch it too i would think
> > -mike
> 
> -checkpatch.pl v0.31 and v0.32 do not detect this for me
> -git format-patch does not seem to have an option to report it
> -git am notices it, but as Albert notes, the procedure is torturous

if you turn on colorization, `git diff` should highlight it as well as `git 
log -p`.  trailing new lines are a bit harder to catch than trailing spaces on 
lines ...

i'm surprised checkpatch didnt catch these ... i guess someone needs to fix 
that up :)

> For now I have added something to my script to find these errors in
> future, just by scanning the patches.

yeah, i wrote my own little check-patches helper as another thing ive seen but 
checkpatch.pl doesnt catch is mixing of tabs and spaces.
	grep -l '^[+].* \t' "$@"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110831/0c20c46f/attachment.pgp