[U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot

Michal Simek monstr at monstr.eu
Thu Sep 1 11:21:31 CEST 2011


Mike Frysinger wrote:
> On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:
>> +	volatile struct temac_reg *regs = priv->regs;
>> +
>> +	regs->lsw = (phy_addr << 5) | reg_addr;
>> +	regs->ctl = MIIMAI | (emac << 10);
> 
> you should still be going through read/write i/o helper funcs rather than 
> relying on the volatile markings

Fixed.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian


More information about the U-Boot mailing list